Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.js extension for web build #501

Closed

Conversation

PonomareVlad
Copy link
Member

@PonomareVlad PonomareVlad commented Nov 1, 2023

Possible solution to fix Next.js builds using Edge Runtime (#435)

How to test:

{
    "dependencies": {
        "grammy": "npm:@ponomarevlad/[email protected]"
    }
}

Full example

logs

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c238c0) 46.24% compared to head (2402cea) 46.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files          19       19           
  Lines        5650     5650           
  Branches      227      227           
=======================================
  Hits         2613     2613           
  Misses       3034     3034           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnorpelSenf
Copy link
Member

The mjs used to ensure that the module is evaluated as ESM. Will renaming the script to js break anything in that regard?

@PonomareVlad
Copy link
Member Author

I will do the tests a little later.

As a last resort it will be possible to define the entire package as a module 🌚

@PonomareVlad
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants